Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganization of css.types.color #15762

Merged
merged 3 commits into from
Apr 16, 2022
Merged

Reorganization of css.types.color #15762

merged 3 commits into from
Apr 16, 2022

Conversation

teoli2003
Copy link
Contributor

This is the reorganization associated with #15646.

One page doesn't exist yet in content, here is the PR: mdn/content#14813

@teoli2003 teoli2003 added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Apr 11, 2022
@teoli2003 teoli2003 requested a review from Elchi3 April 11, 2022 12:02
queengooborg
queengooborg requested changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is looking pretty good to me! I have yet to do a full review, but I noticed something at the top of the file that needs fixing.

css/types/color.json Outdated Show resolved Hide resolved
@teoli2003 teoli2003 requested a review from queengooborg April 16, 2022 06:13
queengooborg
queengooborg approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is LGTM!

@queengooborg queengooborg merged commit 6ec2c23 into mdn:main Apr 16, 2022
@teoli2003 teoli2003 mentioned this pull request Apr 22, 2022
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3

Assignees
No one assigned
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @queengooborg