Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF97 AbortSignal has reason and throwIfAborted #14418

Merged
merged 2 commits into from
Jan 9, 2022

Conversation

hamishwillee
Copy link
Contributor

@hamishwillee hamishwillee commented Jan 4, 2022

FF97 adds support for the AbortSignal reason property and parameter in https://bugzilla.mozilla.org/show_bug.cgi?id=1737771 and for throwIfAborted() in https://bugzilla.mozilla.org/show_bug.cgi?id=1745372.

These were previously supported only by deno in #13380. This PR just adds the support information.

Other FF docs work for this change can be tracked in mdn/content#11593

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 4, 2022
@hamishwillee
Copy link
Contributor Author

@ddbeck Can I please get this reviewed.

@hamishwillee hamishwillee changed the title FF97 AbortSignal has reason FF97 AbortSignal has reason and throwIfAborted Jan 7, 2022
@hamishwillee
Copy link
Contributor Author

PS These are supported now in FF and deno, with intent for the other browsers. Still feels early to remove experimental. Thoughts?

Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@queengooborg queengooborg merged commit adf9834 into mdn:main Jan 9, 2022
jpmedley pushed a commit that referenced this pull request Jan 10, 2022
* FF97 AbortSignal has reason

* Add FF97 support for throwifsupported()
@hamishwillee hamishwillee deleted the patch-4 branch January 11, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants