-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Safari 6.1 #11156
Remove Safari 6.1 #11156
Conversation
I looked into making this changes yesterday on a branch, which I've created as #11157 now. That has a bunch of different commits, and only "Change where iOS is 7" is trivial IMHO. I'd especially want to look into the cases where iOS said 6.1, since that has the same WebKit version as iOS 6. I don't really believe that data, but if we did we'd change iOS 6.1 to 6, not 7. So for those we need to research what it should really be. |
api/Window.json
Outdated
@@ -1670,10 +1670,10 @@ | |||
"version_added": "24" | |||
}, | |||
"safari": { | |||
"version_added": "6.1" | |||
"version_added": "7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using http://mdn-bcd-collector.appspot.com/tests/api/Window/crypto it looks like window.crypto
was actually added in Safari 5.1. Maybe the collector can be used to update a bunch of this data?
I'm marking this as "not ready" as I'm planning to talk to Daniel about what we want to do with Safari 6.1. |
Removing the "not ready" flag -- we've just about come to a conclusion to remove Safari 6.1! |
@vinyldarkscratch was most of this produced by a script so that you can easily recreate it? If so, could you separate it into multiple commits and PRs to make it easier to review? In particular, all the cases where 6.1+6.1 are changed to 7+7 are ones I don't feel need any review at all. Splitting just that out would probably make the rest small enough to review together. |
It was generated by a quick |
A separate PR any APIs that the collector determines were supported before 6.1 would be great. |
79f2511
to
6593ec9
Compare
Current remaining entries are: → css.properties.align-self.flex_context |
@queengooborg those PRs are merged, this now need rebasing. |
Oops, one more: #13888! |
Also merged! |
Alright, this is now ready to go! Whoo! |
* Bump version to v4.1.1 * Add initial release notes * Add release note for #11156 * Add stats * Fix previous release note version
* Bump version to v4.1.1 * Add initial release notes * Add release note for #11156 * Add stats * Fix previous release note version
This PR removes Safari 6.1 from the data and converts all of its entries to Safari 7. Details are described in #9423, but to summarize, it seems that Safari 6.1 and 6.2 are simply backports of Safari 7.0 and 7.1 for older macOS versions, similar to Safari 4.1 and 5.0.