-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RTCPeerConnection #11150
Fix RTCPeerConnection #11150
Conversation
@teoli2003 this is often correct, but depressingly often it's not. See #7545 for more complexities than you're probably interested in regarding events. My advice when adding
Digging through implementation source is often faster than the testing approach, but has many pitfalls of its own. In particular, it's hard to be confident whether some code path firing an event is behind a flag or not. |
"version_added": "22" | ||
}, | ||
"firefox_android": { | ||
"version_added": "44" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Firefox + Firefox for Android data in https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection#browser_compatibility looks pretty implausible, suggesting that the unprefixed RTCPeerConnection
was available on desktop since 22, but that on Android it was prefixed as mozRTCPeerConnection
from 22 to 43, and unprefixed in 44.
That's probably wrong, and the likely error is being spread around more here.
https://mdn-bcd-collector.appspot.com/tests/api/mozRTCPeerConnection can be used to figure out when the prefixed support was added and removed, if you have the appetite for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unprefixing happened in Firefox 44 in the code: https://bugzilla.mozilla.org/show_bug.cgi?id=1155923. So RTCPeerConnection on Fx 22 is impossible.
Note that the removal of the unprefixed version has not happened yet: https://bugzilla.mozilla.org/show_bug.cgi?id=1531812.
I'm adding a commit reflecting this.
I've also sent foolip/mdn-bcd-collector#1246 to improve the collector's ability to detect early support of |
@teoli2003 would you like to give this a final push? I'm happy to review again :) |
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
(Thanks for reminding me of this PR, lost in the list of those waiting review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still lots of Firefox Android data claiming 44 where the Firefox data says something else. This adds one such error, but I'll send a follow-up to fix them all.
Thanks! |
Added two missing events:
onicegatheringstatechange_event
andicecandidateerror_event
(I took their compat info formonicegatheringstatechange
andonicecadidateerror
that were both existing.Added mdn and spec urls for
RTCPeerConnection.getTranceivers
.