add compat data for BatteryManager #1102

germain-gg · 2018-02-15T22:14:41Z

This should solve #968
Are you aware of any other pages that need to be migrated, I'm happy to continue helping 👍

jpmedley · 2018-02-15T22:19:51Z

api/BatteryManager.json

+        "mdn_url": "https://developer.mozilla.org/docs/Web/API/BatteryManager",
+        "support": {
+          "chrome": {
+            "version_added": "39"


This should be "38"

jpmedley · 2018-02-15T22:21:14Z

api/BatteryManager.json

+            "version_added": false
+          },
+          "chrome_android": {
+            "version_added": "42",


jpmedley · 2018-02-15T22:21:22Z

api/BatteryManager.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/BatteryManager/charging",
+          "support": {
+            "chrome": {
+              "version_added": "39"


jpmedley · 2018-02-15T22:21:41Z

api/BatteryManager.json

+              "version_added": false
+            },
+            "chrome_android": {
+              "version_added": "42",


jpmedley · 2018-02-15T22:21:49Z

api/BatteryManager.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/BatteryManager/chargingTime",
+          "support": {
+            "chrome": {
+              "version_added": "39"


jpmedley · 2018-02-15T22:24:32Z

api/BatteryManager.json

+              "version_added": false
+            },
+            "chrome_android": {
+              "version_added": "42",


jpmedley · 2018-02-15T22:24:40Z

api/BatteryManager.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/BatteryManager/ondischargingtimechange",
+          "support": {
+            "chrome": {
+              "version_added": "39"


jpmedley · 2018-02-15T22:25:02Z

api/BatteryManager.json

+              "version_added": false
+            },
+            "chrome_android": {
+              "version_added": "42",


jpmedley · 2018-02-15T22:25:11Z

api/BatteryManager.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/BatteryManager/onlevelchange",
+          "support": {
+            "chrome": {
+              "version_added": "39"


jpmedley · 2018-02-15T22:25:25Z

api/BatteryManager.json

+              "version_added": false
+            },
+            "chrome_android": {
+              "version_added": "42",


germain-gg · 2018-02-15T23:35:40Z

Updated everything you commented on @jpmedley . Thanks!

teoli2003

@gsouquet It is really really good. Too very special cases to fix (I think you just hit too of weirdest BCD cases possible).

teoli2003 · 2018-02-16T09:37:29Z

api/BatteryManager.json

+              "version_removed": "16",
+              "prefix": "moz"
+            },
+            {


Ok, this one is a bit tricky
So from 10-16 it was prefixed moz, from 16-52 activated by default, and 52 onwards deactivated by default.
So this is how to describe it:
[
{
version_added: "16",
version_removed:"52"
},
{
"version_added": "10",
"version_removed": "16",
"prefix": "moz"
},
{
"version_added": "52",
"flags": [
{
"type": "preference",
"name": "dom.battery.enabled"
}
],
"notes": [
"Disabled by default in Firefox 10.0, but can be enabled setting the preference dom.battery.enabled to true. Starting with Firefox 11.0, mozBattery is enabled by default. The Battery API is currently supported on Android, Windows, and Linux with UPower installed. Support for MacOS is available starting with Gecko 18.0 (Firefox 18.0 / Thunderbird 18.0 / SeaMonkey 2.15). Firefox also provide support for the deprecated <a href='https://developer.mozilla.org/docs/Web/API/Navigator/battery' title='The battery read-only property returns a BatteryManager provides information about the system's battery charge level; provides also some new events you can handle to monitor the battery status. This implements the Battery Status API; see that documentation for additional details, a guide to using the API, and sample code.'>navigator.battery."
]
}
]

(Indentation likely a bit incorrect).

nit: we don't write with Gecko 18.0 (Firefox 18.0 / Thunderbird 18.0 / SeaMonkey 2.15) any more, replace this by Firefox 18. (And Firefox 11, without the .0)

teoli2003 · 2018-02-16T10:28:58Z

api/BatteryManager.json

+            "version_added": "25"
+          },
+          "safari_ios": {
+            "version_added": false


This one is a very special case: it has been added in an unknown version, and removed later in an unknown version (wasn't able to find which ones...)
So:
{
"version_added": true,
"version_removed": true
}

germain-gg · 2018-02-16T13:57:18Z

@teoli2003 Thanks for your feedback really appreciated. I guess I have a better understanding on how to structure all of this.

I guess all the requested changes are now fixed 👍

How do you find all of those compat data in the first place? Is it just a case of you going through all the vendors changelog?

Thanks!

Elchi3 · 2018-02-28T12:56:16Z

How do you find all of those compat data in the first place? Is it just a case of you going through all the vendors changelog?

Yeah, source code, bug trackers, and changelogs mostly :-)

Comments addressed

Elchi3

Thank you!

Bug fixed in Chromium 42: https://bugs.chromium.org/p/chromium/issues/detail?id=401553 https://storage.googleapis.com/chromium-find-releases-static/13e.html#13e397e55501bee3903bfe46edfd56f2442c1f11 In mdn#1102 without discussion: - deprecated - webview_android version

Summary of changes: - Remove navigator.battery, which has been removed since 2013/2016 in Chrome and Firefox respectively. - Simplify Firefox support to only represent when it was on by default for web content. Flags before that and chrome-only after is removed. - Remove claims of prefixes on BatteryManager, the only prefixes here have been navigator.mozBattery and navigator.webkitBattery. - Don't claim it's deprecated, https://w3c.github.io/battery/ is still a "real" spec and Chromium hasn't deprecated it. - Scope the chargingTime/dischargingTime notes to just those entries, and treat it as fixed in Chromium 42 (see below). The chargingTime/dischargingTime issue was fixed in Chromium 42: https://bugs.chromium.org/p/chromium/issues/detail?id=401553 https://storage.googleapis.com/chromium-find-releases-static/13e.html#13e397e55501bee3903bfe46edfd56f2442c1f11 All existing versions were treated as untrustworthy and data was mirrored to all Chromium browsers. Data originally from mdn#1102.

Summary of changes: - Remove navigator.battery, which has been removed since 2013/2016 in Chrome and Firefox respectively. - Treat BatteryManager as only supported since navigator.getBattery() was supported, making the data consistent but technically wrong. - Simplify Firefox support to only represent when it was on by default for web content. Flags before that and chrome-only after is removed. - Remove claims of prefixes on BatteryManager, the only prefixes here have been navigator.mozBattery and navigator.webkitBattery. - Don't claim it's deprecated, https://w3c.github.io/battery/ is still a "real" spec and Chromium hasn't deprecated it. - Scope the chargingTime/dischargingTime notes to just those entries, and treat it as fixed in Chromium 42 (see below). The chargingTime/dischargingTime issue was fixed in Chromium 42: https://bugs.chromium.org/p/chromium/issues/detail?id=401553 https://storage.googleapis.com/chromium-find-releases-static/13e.html#13e397e55501bee3903bfe46edfd56f2442c1f11 All existing versions were treated as untrustworthy and data was mirrored to all Chromium browsers. Data originally from mdn#1102.

Summary of changes: - Remove navigator.battery, which has been removed since 2013/2016 in Chrome and Firefox respectively. - Treat BatteryManager as only supported since navigator.getBattery() was supported, making the data consistent but technically wrong. - Simplify Firefox support to only represent when it was on by default for web content. Flags before that and chrome-only after is removed. - Remove claims of prefixes on BatteryManager, the only prefixes here have been navigator.mozBattery and navigator.webkitBattery. - Don't claim it's deprecated, https://w3c.github.io/battery/ is still a "real" spec and Chromium hasn't deprecated it. - Scope the chargingTime/dischargingTime notes to just those entries, and treat it as fixed in Chromium 42 (see below). The chargingTime/dischargingTime issue was fixed in Chromium 42: https://bugs.chromium.org/p/chromium/issues/detail?id=401553 https://storage.googleapis.com/chromium-find-releases-static/13e.html#13e397e55501bee3903bfe46edfd56f2442c1f11 Data originally from mdn#1102. There was no evidence for or discussion on the webview_android version being 40. All existing versions were treated as untrustworthy and data was mirrored to all Chromium browsers.

Summary of changes: - Remove navigator.battery, which has been removed since 2013/2016 in Chrome and Firefox respectively. - Treat BatteryManager as only supported since navigator.getBattery() was supported, making the data consistent but technically wrong. - Simplify Firefox support to only represent when it was on by default for web content. Flags before that and chrome-only after is removed. - Remove claims of prefixes on BatteryManager, the only prefixes here have been navigator.mozBattery and navigator.webkitBattery. - Don't claim it's deprecated, https://w3c.github.io/battery/ is still a "real" spec and Chromium hasn't deprecated it. - Scope the chargingTime/dischargingTime notes to just those entries, and treat it as fixed in Chromium 42 (see below). The chargingTime/dischargingTime issue was fixed in Chromium 42: https://bugs.chromium.org/p/chromium/issues/detail?id=401553 https://storage.googleapis.com/chromium-find-releases-static/13e.html#13e397e55501bee3903bfe46edfd56f2442c1f11 Data originally from #1102. There was no evidence for or discussion on the webview_android version being 40. All existing versions were treated as untrustworthy and data was mirrored to all Chromium browsers.

add compat data for BatteryManager

39aae6f

jpmedley suggested changes Feb 15, 2018

View reviewed changes

update chrome and chrome_android compat data for BatteryManager

21ead2a

jpmedley approved these changes Feb 16, 2018

View reviewed changes

teoli2003 previously requested changes Feb 16, 2018

View reviewed changes

teoli2003 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 16, 2018

update Safari iOS and Firefox BatteryManager compat data

b629e5e

Elchi3 approved these changes Feb 28, 2018

View reviewed changes

Elchi3 merged commit d7b2c79 into mdn:master Feb 28, 2018

Elchi3 mentioned this pull request Mar 1, 2018

Add compat data for BatteryManager #968

Closed

9 tasks

dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018

Add compat data for BatteryManager (mdn#1102)

64d35b4

foolip mentioned this pull request Mar 26, 2021

Clean up the data for navigator.getBattery() #9626

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add compat data for BatteryManager #1102

add compat data for BatteryManager #1102

germain-gg commented Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

jpmedley Feb 15, 2018

germain-gg commented Feb 15, 2018

teoli2003 left a comment

teoli2003 Feb 16, 2018

teoli2003 Feb 16, 2018

teoli2003 Feb 16, 2018

germain-gg commented Feb 16, 2018

Elchi3 commented Feb 28, 2018

Elchi3 left a comment

add compat data for BatteryManager #1102

add compat data for BatteryManager #1102

Conversation

germain-gg commented Feb 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

germain-gg commented Feb 15, 2018

teoli2003 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

germain-gg commented Feb 16, 2018

Elchi3 commented Feb 28, 2018

Elchi3 left a comment

Choose a reason for hiding this comment