-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Safari versions for IDB* API #10920
Conversation
This PR adds real values for Safari (Desktop and iOS/iPadOS) for the `IDB*` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.1.4). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/IDB*
@vinyldarkscratch there are conflicts now, I'll hold off with review until pinged. |
@foolip Ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With all the batch changes I asked more annoying questions about anything that didn't fit the pattern :)
api/IDBObjectStore.json
Outdated
@@ -966,10 +966,10 @@ | |||
"version_added": "14" | |||
}, | |||
"safari": { | |||
"version_added": "7" | |||
"version_added": "10.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is openKeyCursor
and is later than the rest. Is this based on mdn-bcd-collector results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is pretty much all from the collector results, aside from ensuring iOS stays marked as "8" and not earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/openKeyCursor, can you check if the data for that is also wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've compared https://mdn-bcd-collector.appspot.com/tests/api/IDBObjectStore and https://mdn-bcd-collector.appspot.com/tests/api/IDBIndex in Safari 10 and 10.1, and there's a lot more than this that came in 10.1.
How about backing this out and making all of those changes as a single PR? I'm not sure I understand why the collector isn't updating all of the data, but it looks like api.IDBIndex.openKeyCursor was in Safari 8 and just temporarily gone. Something weird happened at any rate, which is better to split out.
api/IDBTransaction.json
Outdated
@@ -661,10 +661,10 @@ | |||
"version_added": "35" | |||
}, | |||
"safari": { | |||
"version_added": true | |||
"version_added": "10.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is objectStoreNames
, confirmed manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's back this out too, I'm no longer trusting of the 10.1 versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed with some npm run traverse safari_ios api $version
calls that there's no iOS data <8 now.
Hmm, now I'm having second thoughts in light of #9423, where we're contemplating just removing 6.1 and 6.2 as releases. If we do, we'd change these 6.1 back to 7 again. So... uh... |
OK, so final deal. I sent #11145 and think we should go with the 6.1→7 rewrite in #9423 (comment). Can you back out all the 7→6.1 changes here? |
This all also matches the api.WindowOrWorkerGlobalScope.indexedDB.worker_support entry: browser-compat-data/api/WindowOrWorkerGlobalScope.json Lines 901 to 906 in fa9e3ca
|
@vinyldarkscratch this is now only blocked on backing out some 10.1 / 10.3 versions that seems complicated. |
This PR adds real values for Safari (Desktop and iOS/iPadOS) for the
IDB*
API, based upon results from the mdn-bcd-collector project (v3.1.4).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/IDB*