Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chromium versions for BluetoothRemoteGATTService API #10197

Merged
merged 8 commits into from
Jul 14, 2021
Merged

Update Chromium versions for BluetoothRemoteGATTService API #10197

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9be61b9
Update Edge versions for BluetoothRemoteGATTService API
queengooborg May 2, 2021
663e389
Fix Chrome data
queengooborg May 14, 2021
3335289
Simplify data for subfeatures
queengooborg May 14, 2021
ae97cb3
Cleanup Edge data a little bit
queengooborg May 14, 2021
38e5f01
Simplify OS-varying data
queengooborg May 21, 2021
ab0a6b5
Merge branch 'main' into api/BluetoothRemoteGATTService/edge-corrections
queengooborg May 21, 2021
cffac2e
Add partial implementation
queengooborg Jun 9, 2021
5529bb6
Update api/BluetoothRemoteGATTService.json
foolip Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 42 additions & 180 deletions api/BluetoothRemoteGATTService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,18 @@
"chrome": [
{
"version_added": "56",
"notes": "macOS only."
"notes": "Before Chrome 70, this feature was only supported in macOS. In Chrome 70, support was added for Windows 10."
},
{
"version_added": "56",
"notes": "Linux and versions of Windows earlier than 10.",
"notes": "In Linux and versions of Windows earlier than 10, this flag must be enabled.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "70",
"notes": "Windows 10."
}
],
"chrome_android": {
Expand All @@ -32,22 +28,18 @@
"edge": [
{
"version_added": "79",
"notes": "macOS only."
"notes": "Supported by default only on macOS and Windows 10."
},
{
"version_added": "79",
"notes": "Linux and versions of Windows earlier than 10.",
"notes": "In Linux and versions of Windows earlier than 10, this flag must be enabled.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "79",
"notes": "Windows 10."
}
],
"firefox": {
Expand All @@ -62,22 +54,18 @@
"opera": [
{
"version_added": "43",
"notes": "macOS only."
"notes": "Before Before Opera 57, this feature was only supported in macOS. In Before Opera 57, support was added for Windows 10."
},
{
"version_added": "43",
"notes": "Linux and versions of Windows earlier than 10.",
"notes": "In Linux and versions of Windows earlier than 10, this flag must be enabled.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "57",
"notes": "Windows 10."
}
],
"opera_android": {
Expand Down Expand Up @@ -108,13 +96,13 @@
"spec_url": "https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattservice-device",
"support": {
"chrome": {
"version_added": false
"version_added": "56"
},
"chrome_android": {
"version_added": false
"version_added": "56"
},
"edge": {
"version_added": false
"version_added": "79"
queengooborg marked this conversation as resolved.
Show resolved Hide resolved
},
"firefox": {
"version_added": false
Expand All @@ -125,27 +113,9 @@
"ie": {
"version_added": false
},
"opera": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with simplifying all of this repeated OS and flag information since it's already on the parent feature. But it does mean that information won't be visible on a page like https://developer.mozilla.org/en-US/docs/Web/API/BluetoothRemoteGATTService/getCharacteristic#browser_compatibility.

@ddbeck how do you think we should deal with cases like this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some disagreement on this point. See #6509 for the broader issue.

My approach to flags has been to only represent the flag on the feature that requires the flag, not its descendants (unless the flags differ). For example, a CSS property behind a flag doesn't need to duplicate the flag data on subfeatures for property values. This does lead to a poorer presentation for individual interface member pages, however. In those cases I don't think it's too bad: for SomeFlaggedInterface.method(), you'd get an informative SomeFlaggedInterface is not defined error.

But since there's no consensus, I'm happy to allow anything that looks reasonable. If you think it'd be preferable to have flags inherit, then go for it, but I'm not going to ask for it myself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go along with removing the flags on subfeatures here. I don't know what I think should be the guideline :)

{
"version_added": "43",
"notes": "macOS only."
},
{
"version_added": "43",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "57",
"notes": "Windows 10."
}
],
"opera": {
"version_added": "43"
},
"opera_android": {
"version_added": "43"
},
Expand Down Expand Up @@ -174,51 +144,15 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/BluetoothRemoteGATTService/getCharacteristic",
"spec_url": "https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattservice-getcharacteristic",
"support": {
"chrome": [
{
"version_added": "56",
"notes": "macOS only."
},
{
"version_added": "56",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "70",
"notes": "Windows 10."
}
],
"chrome": {
"version_added": "56"
},
"chrome_android": {
"version_added": "56"
},
"edge": [
{
"version_added": "79",
"notes": "macOS only."
},
{
"version_added": "79",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "79",
"notes": "Windows 10."
}
],
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": false
},
Expand All @@ -228,27 +162,9 @@
"ie": {
"version_added": false
},
"opera": [
{
"version_added": "43",
"notes": "macOS only."
},
{
"version_added": "43",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "57",
"notes": "Windows 10."
}
],
"opera": {
"version_added": "43"
},
"opera_android": {
"version_added": "43"
},
Expand Down Expand Up @@ -278,13 +194,13 @@
"spec_url": "https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattservice-getcharacteristics",
"support": {
"chrome": {
"version_added": false
"version_added": "56"
},
"chrome_android": {
"version_added": false
"version_added": "56"
},
"edge": {
"version_added": false
"version_added": "79"
},
"firefox": {
"version_added": false
Expand All @@ -296,10 +212,10 @@
"version_added": false
},
"opera": {
"version_added": false
"version_added": "43"
},
"opera_android": {
"version_added": false
"version_added": "43"
},
"safari": {
"version_added": false
Expand All @@ -308,7 +224,7 @@
"version_added": false
},
"samsunginternet_android": {
"version_added": false
"version_added": "6.0"
},
"webview_android": {
"version_added": false
Expand All @@ -327,13 +243,13 @@
"spec_url": "https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattservice-isprimary",
"support": {
"chrome": {
"version_added": false
"version_added": "56"
},
"chrome_android": {
"version_added": false
"version_added": "56"
},
"edge": {
"version_added": false
"version_added": "79"
},
"firefox": {
"version_added": false
Expand All @@ -345,10 +261,10 @@
"version_added": false
},
"opera": {
"version_added": false
"version_added": "43"
},
"opera_android": {
"version_added": false
"version_added": "43"
},
"safari": {
"version_added": false
Expand All @@ -357,7 +273,7 @@
"version_added": false
},
"samsunginternet_android": {
"version_added": false
"version_added": "6.0"
},
"webview_android": {
"version_added": false
Expand All @@ -375,51 +291,15 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/BluetoothRemoteGATTService/uuid",
"spec_url": "https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothremotegattservice-uuid",
"support": {
"chrome": [
{
"version_added": "56",
"notes": "macOS only."
},
{
"version_added": "56",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "70",
"notes": "Windows 10."
}
],
"chrome": {
"version_added": "56"
},
"chrome_android": {
"version_added": "56"
},
"edge": [
{
"version_added": "79",
"notes": "macOS only."
},
{
"version_added": "79",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "79",
"notes": "Windows 10."
}
],
"edge": {
"version_added": "79"
},
"firefox": {
"version_added": false
},
Expand All @@ -429,27 +309,9 @@
"ie": {
"version_added": false
},
"opera": [
{
"version_added": "43",
"notes": "macOS only."
},
{
"version_added": "43",
"notes": "Linux and versions of Windows earlier than 10.",
"flags": [
{
"type": "preference",
"name": "#enable-experimental-web-platform-features",
"value_to_set": "enabled"
}
]
},
{
"version_added": "57",
"notes": "Windows 10."
}
],
"opera": {
"version_added": "43"
},
"opera_android": {
"version_added": "43"
},
Expand Down