Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require notes for partial_implementation #4162

Closed
14 of 20 tasks
ddbeck opened this issue May 15, 2019 · 1 comment · Fixed by #15924
Closed
14 of 20 tasks

Require notes for partial_implementation #4162

ddbeck opened this issue May 15, 2019 · 1 comment · Fixed by #15924
Labels
enhancement Nice to have features. schema Isses or pull requests regarding the JSON schema files used in this project.

Comments

@ddbeck
Copy link
Collaborator

ddbeck commented May 15, 2019 •
edited by queengooborg
Loading

The partial_implementation data alone isn't very useful. We should consider requiring the notes property for any support statement that has partial_implementation: true. I started doing the schema work to do this, but it turned out there are more such cases than I would've guessed. At the moment, such support statements appear in the following features:

  • api.CSS.supports
  • api.Crypto.subtle
  • api.GeometryUtils
  • api.SubtleCrypto
  • api.VisualViewport.onresize
  • api.VisualViewport.onscroll
  • api.VisualViewport.resize_event
  • api.VisualViewport.scroll_event
  • api.WindowOrWorkerGlobalScope.indexedDB
  • css.properties.appearance
  • css.properties.appearance.compat
  • css.properties.filter
  • css.properties.font-feature-settings
  • css.properties.font-size.rem_values
  • css.properties.text-decoration.shorthand
  • html.elements.input.input-range
  • html.elements.script.integrity
  • html.elements.source.sizes
  • html.elements.source.srcset
  • webextensions.api.events.Event

Note: many of these features have more than support statement with a partial_implementation and no note.
@ddbeck ddbeck added enhancement Nice to have features. schema Isses or pull requests regarding the JSON schema files used in this project. labels May 15, 2019
@wbt wbt mentioned this issue May 15, 2019
Closed
@Elchi3
Copy link
Member

Elchi3 commented May 16, 2019

Thanks Daniel, I strongly support enforcing this in the schema.

css.properties.appearance
css.properties.appearance.compat

I just stumbled upon these two. In fact, here, we don't need a note but in my opinion we need to properly break out all values in their own rows (or objects) in the data. This might apply to other features listed in this issue as well.

@ddbeck ddbeck mentioned this issue Dec 4, 2019
Closed
@ddbeck ddbeck mentioned this issue Nov 10, 2020
Merged
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Nov 13, 2020
@sideshowbarker
Add note re Safari <9 partial srcset/sizes support
bb3d705 
This change adds notes fields to explain why html.elements.source.srcset
html.elements.source.sizes are marked as partial_implementation for Safari 7.

Relates to mdn#4162
@sideshowbarker sideshowbarker mentioned this issue Nov 13, 2020
Merged
ddbeck added a commit that referenced this issue Nov 13, 2020
@ddbeck
Add data guideline: partial_implementation requires a note (#7332)
2f96b45 
* Add a guideline that requires notes for "partial_implementation"
* Update TOC
* Group related partial_implementation guidelines
* Link to PR

A step toward #4162.
sideshowbarker added a commit to w3c/browser-compat-data that referenced this issue Nov 17, 2020
@sideshowbarker
Add note re Safari <9 partial srcset/sizes support
0e74385 
This change adds notes fields to explain why html.elements.source.srcset
html.elements.source.sizes are marked as partial_implementation for Safari 7.

Relates to mdn#4162
ddbeck pushed a commit that referenced this issue Jan 28, 2021
@sideshowbarker
Add note re Safari <9 partial srcset/sizes support (#7353)
89bcada 
This change adds notes fields to explain why html.elements.source.srcset
html.elements.source.sizes are marked as partial_implementation for Safari 7.

Relates to #4162
@queengooborg queengooborg mentioned this issue Apr 20, 2022
Merged
@foolip foolip mentioned this issue May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Nice to have features. schema Isses or pull requests regarding the JSON schema files used in this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require notes if partial_implementation is true queengooborg/browser-compat-data
2 participants
@ddbeck @Elchi3