Skip to content

Commit

Permalink
Require that version_removed is either a string or true
Browse files Browse the repository at this point in the history
Setting it explicitly to null or false is meaningless.
  • Loading branch information
foolip committed Feb 5, 2021
1 parent 92173f4 commit 0f831e2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions http/headers/x-xss-protection.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@
"version_added": true
},
"samsunginternet_android": {
"version_added": true,
"version_removed": false
"version_added": true
},
"webview_android": {
"version_added": false
Expand Down
12 changes: 6 additions & 6 deletions schemas/compat-data-schema.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,14 +217,14 @@ entirely unknown. Examples:

#### `version_removed`

Contains a string with the version number the sub-feature was
removed in. It may also be a Boolean value of (`true` or `false`), or the
`null` value.
Contains a string with the version number the sub-feature was removed in.
It may also be `true`, meaning that it is unknown in which version support
was removed.

Default values:

- If `version_added` is set to `true`, `false`, or a string, `version_removed` defaults to `false`.
- if `version_added` is set to `null`, the default value of `version_removed` is also `null`.
- If `version_added` is set to `null`, the default value of `version_removed` is also `null`.

Examples:

Expand All @@ -237,12 +237,12 @@ Examples:
}
```

- Not removed (default if `version_added` is not `null`):
- Removed in some version after 3.5:

```json
{
"version_added": "3.5",
"version_removed": false
"version_removed": true
}
```

Expand Down

0 comments on commit 0f831e2

Please sign in to comment.