(#25) Use Google's UUID for generating compose's identifier

mdelapenya · Nov 18, 2019 · 72e1dd5 · 72e1dd5
1 parent dfb14b0
commit 72e1dd5
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 37 deletions.
diff --git a/compose_test.go b/compose_test.go
@@ -5,13 +5,14 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/google/uuid"
 	"github.com/stretchr/testify/assert"
 )
 
 func TestLocalDockerCompose(t *testing.T) {
 	path := "./testresources/docker-compose.yml"
 
-	identifier := strings.ToLower(RandomString(6))
+	identifier := strings.ToLower(uuid.New().String())
 
 	compose := NewLocalDockerCompose([]string{path}, identifier)
 
@@ -36,7 +37,7 @@ func TestLocalDockerCompose(t *testing.T) {
 func TestLocalDockerComposeWithEnvironment(t *testing.T) {
 	path := "./testresources/docker-compose.yml"
 
-	identifier := strings.ToLower(RandomString(6))
+	identifier := strings.ToLower(uuid.New().String())
 
 	compose := NewLocalDockerCompose([]string{path}, identifier)
 	destroyFn := func() {
@@ -66,7 +67,7 @@ func TestLocalDockerComposeWithMultipleComposeFiles(t *testing.T) {
 		"testresources/docker-compose-override.yml",
 	}
 
-	identifier := strings.ToLower(RandomString(6))
+	identifier := strings.ToLower(uuid.New().String())
 
 	compose := NewLocalDockerCompose(composeFiles, identifier)
 	destroyFn := func() {

diff --git a/go.mod b/go.mod
@@ -14,6 +14,7 @@ require (
 	github.com/go-redis/redis v6.15.5+incompatible
 	github.com/go-sql-driver/mysql v1.4.1
 	github.com/gogo/protobuf v1.2.0 // indirect
+	github.com/google/uuid v1.1.1
 	github.com/gorilla/context v1.1.1 // indirect
 	github.com/gorilla/mux v1.6.2 // indirect
 	github.com/kr/pretty v0.1.0 // indirect

diff --git a/go.sum b/go.sum
@@ -31,6 +31,8 @@ github.com/golang/protobuf v1.2.0 h1:P3YflyNX/ehuJFLhxviNdFxQPkGK5cDcApsge1SqnvM
 github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
 github.com/google/go-cmp v0.2.0 h1:+dTQ8DZQJz0Mb/HjFlkptS1FeQ4cWSnN941F8aEG4SQ=
 github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M=
+github.com/google/uuid v1.1.1 h1:Gkbcsh/GbpXz7lPftLA3P6TYMwjCLYm83jiFQZF/3gY=
+github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/gorilla/context v1.1.1/go.mod h1:kBGZzfjB9CEq2AlWe17Uuf7NDRt0dE0s8S51q0aT7Yg=
 github.com/gorilla/mux v1.6.2 h1:Pgr17XVTNXAk3q/r4CpKzC5xBM/qW1uVLV+IhRZpIIk=
 github.com/gorilla/mux v1.6.2/go.mod h1:1lud6UwP+6orDFRuTfBEV8e9/aOM/c4fVVCaMa2zaAs=

diff --git a/utility.go b/utility.go
diff --git a/utility_test.go b/utility_test.go