Update torch_transform and tests #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the `torch_transform` function where the image was being re-enclosed in a list multiple times (the respective methods on the expected image then failed because the items were instead themselves lists). The bug was never caught by the tests because only one transform was ever performed. The tests have also been updated to now catch this.
|
👍 |
|
Hi @lewisbelcher, many thanks, I have merged and will update the version on PyPI soon. Sorry for the delays, I have had very little time right now for any Augmentor work recently. However, I'll get a new version out as a priority so that people can update with pip. Thanks again! |
|
No problem! Thanks to you too for the package 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the
torch_transformfunction where the image wasbeing re-enclosed in a list multiple times (the respective methods on
the expected image then failed because the items were instead themselves
lists).
The bug was never caught by the tests because only one transform was
ever performed. The tests have also been updated to now catch this.
(Rounding the random sample was also unnecessary).