Add parser for tty containers #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function parseTty (chunk, enc, cb) { | ||
| this.payload.append(chunk) | ||
|
|
||
| publish.bind(this)() |
There was a problem hiding this comment.
this will be very very slow. Would you mind attaching publish to result, and calling it straight from there?
|
Sure, I have attached publish to result, alternatively I have pushed https://github.com/cammellos/docker-loghose/tree/add-tty-parser-result which one do you prefer? |
mcollina
added a commit
that referenced
this pull request
Jan 17, 2016
Add parser for tty containers
|
Released as 0.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits add a parser for containers with the tty flag set:
Before attaching a container, it inspects it to check if tty is enabled.
If it is enabled, it will skip the parsing of the header, as not sent by docker API.
Let me know if you would like me to change something!
Thanks
andrea