Skip to content

Commit

Permalink
📝 Remove requirement to test w/o ACL as that just got removed
Browse files Browse the repository at this point in the history
  • Loading branch information
foosel committed Oct 21, 2020
1 parent c0c6dd7 commit a3dd2c6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,7 @@ and branching strategy.
An [automatic build workflow](https://github.com/OctoPrint/OctoPrint/actions?query=workflow%3ABuild)
is in place that will run these checks - if they fail your PR will be marked accordingly.
10. **Test your changes thoroughly**. That also means testing with usage
scenarios you don't normally use, e.g. if you only use access control, test
without and vice versa. If you only test with your printer, test with the
scenarios you don't normally use. If you only test with your printer, test with the
virtual printer and vice versa. State in your pull request how you tested
your changes. Ideally **add unit tests** - OctoPrint severely lacks in that
department, but we are trying to change that, so any new code already covered
Expand Down

0 comments on commit a3dd2c6

Please sign in to comment.