Fix a clippy warning when using clone_from = "true" #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2775ea1 to
61ae236
Compare
61ae236 to
b64af8a
Compare
|
Any feedbacks? I'd like to add clippy on CI, and I'm only blocked by this warning. |
|
Any news? @mcarton do you need help in maintaining this crate? |
Merged
|
Thanks, I cherry-picked some commits in #81 and released it as v2.1.3. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also cleaned clippy warning in test, activated
cargo clippy --all-targetsto have clippy running on tests, and some fmt in the modified files.Each modification is in a different commit, so I can remove some if you prefer.
Fixes #74