-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "full" feature from syn #38
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
This seems to have broken pub struct Bar { x: u32, y: u32 }
#[derive(Derivative)]
#[derivative(Default)]
pub struct Foo {
#[derivative(Default(value="Bar {x:42, y:42}"))]
a: Bar,
#[derivative(Default(value="[42;2]"))]
b: [u32; 2],
} Using commit fbbd067 you get either
or
|
Looks like Line 370 in 0bd0e52
|
kankri
added a commit
to kankri/rust-derivative
that referenced
this pull request
Aug 23, 2019
PR mcarton#38 made Default expressions with e.g. list values fail and there weren't any tests for them.
kankri
pushed a commit
to kankri/rust-derivative
that referenced
this pull request
Aug 23, 2019
Remove "full" feature from syn
kankri
added a commit
to kankri/rust-derivative
that referenced
this pull request
Aug 23, 2019
PR mcarton#38 made Default expressions with e.g. list values fail and there weren't any tests for them.
kankri
added a commit
to kankri/rust-derivative
that referenced
this pull request
Aug 23, 2019
PR mcarton#38 made Default expressions with e.g. list values fail and there weren't any tests for them.
That did the trick, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the library might not need to use the
full
feature ofsyn
. This PR removes it to potentially help improve compile times for end users. If I'm missing something please let me know =).