Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update syn and quote to latest versions #25

Closed
azriel91 opened this issue Oct 16, 2018 · 1 comment
Closed

Update syn and quote to latest versions #25

azriel91 opened this issue Oct 16, 2018 · 1 comment

Comments

@azriel91
Copy link
Contributor

azriel91 commented Oct 16, 2018 •
edited
Loading

One of my projects compiles multiple versions of syn and quote due to different crate dependencies using different versions of these crates. To reduce the number of crates I have to build, I'm going around bumping the syn and quote versions to 0.15 and 0.6 (current latest of each).

Hopefully you don't mind taking a PR for this: #26
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 16, 2018
@azriel91
Updated syn and quote to 0.15 and 0.6.
9da95ec 
Also updated code to compile, but not yet logically correct.

Issue mcarton#25
@azriel91 azriel91 mentioned this issue Oct 16, 2018
Merged
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Updated syn and quote to 0.15 and 0.6.
821eb9a 
Also updated code to compile, but not yet logically correct.

Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Fixed token generation in matcher.rs
c4e4313 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Fixed Debug derived code.
1e76f3e 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Fixed derive Default on container.
83d7aaf 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Fixed debug derive generated code.
84b82f4 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Corrected type generics computation.
2b710f7 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Fixed WhereClause parsing.
46db15c 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Replaced parse_str_to_type call with syn::parse_str.
f1abbef 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Fixed custom debug implementation derive.
7349fc4 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Updated CHANGELOG.md.
598040f 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 17, 2018
@azriel91
Updated code to work on stable Rust.
9cc5267 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 18, 2018
@azriel91
Fixed derive-partial-eq compile failure test.
9ff0fc5 
Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 18, 2018
@azriel91
Fixed PartialEq and Eq bounds generation.
05f6341 
Also added tests to catch these cases.

Issue mcarton#25
azriel91 added a commit to azriel91/rust-derivative that referenced this issue Oct 19, 2018
@azriel91
Ensure PhantomData type bounds are ignored.
723429a 
Added tests to catch these cases as well.

Issue mcarton#25
@mcarton
Copy link
Owner

mcarton commented Oct 20, 2018

Fixed in #26.

@mcarton mcarton closed this as completed Oct 20, 2018
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Updated syn and quote to 0.15 and 0.6.
fb57110 
Also updated code to compile, but not yet logically correct.

Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed token generation in matcher.rs
68802fb 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed Debug derived code.
db28117 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed derive Default on container.
bc3aa90 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed debug derive generated code.
b25d004 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Corrected type generics computation.
a003f3e 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed WhereClause parsing.
5e5c548 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Replaced parse_str_to_type call with syn::parse_str.
3eafc38 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed custom debug implementation derive.
b4e25e8 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Updated CHANGELOG.md.
fb5a8d4 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Updated code to work on stable Rust.
e01dc3b 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed derive-partial-eq compile failure test.
442c695 
Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Fixed PartialEq and Eq bounds generation.
12e4bd1 
Also added tests to catch these cases.

Issue mcarton#25
kankri pushed a commit to kankri/rust-derivative that referenced this issue Aug 23, 2019
@azriel91
Ensure PhantomData type bounds are ignored.
3655851 
Added tests to catch these cases as well.

Issue mcarton#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azriel91 @mcarton