test: remove redundant url variable #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thank you! |
jordyvanderhaegen
added a commit
that referenced
this pull request
Dec 18, 2024
* Preserve "locale" cookie value on redirect to localized URL * Fix test * test: remove redundant url variable (#922) * test: remove redundant url variable * test: refactor static property to a constant * Draft first SetLanguage Middleware. LocaleMapping has been extracted to its own middleware. * Save readme to README_LEGACY.md * Slowly update Readme to 3.x * Remove outdated caching readme * Fix currentLocale call * Remove custom cache * Set current locale in middleware * Define macro route * use Constructor property promotion * Remove setLocale, no longer used. Provide function to set locale for middleware. * use constructor property promotion * Remove set locale. Should be set via middleware. * Allow to set locale via middleware. * Update usage section * Remove cache commands * Ignore IDE files * Ignore IDE files * fix: macro being registered multiple times * tests: update route registration to use new localized macro * Ensure default routes are always present Initially, I thought default routes might not be required, but after reviewing the current package behavior, I confirmed they are always needed. This is because `LaravelLocalization::setLocale()` simply returns the first URL segment if it matches a supported locale. * chore: remove redundant exception class * Restrict {locale} parameter to configuration values. * Add tests for LocaleSetMiddleware * Restrict {locale} parameter to configuration values. * Fix tests * Remove unintended gitignore file * chore: cleanup old route caching leftovers * Rename middleware * Mark todo for skip question * Add default locale * Rename test to match testcase * Rename SetLocale Test class * Use supported locales from LaravelLocalization * Avoid code duplications * Restore getCurrentLocaleRegional * Avoid code duplication * Change visibility of constructor properties * chore: improve version references * fix: call to undefined method --------- Co-authored-by: Oleksandr Kovpashko <o.kovpashko@gmail.com> Co-authored-by: Adam Nielsen <info@drnielsen.de> Co-authored-by: jordyvanderhaegen <jordy.vanderhaegen@gmail.com> Co-authored-by: jordyvanderhaegen <jordy@esign.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.