Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Laravel < 6 for Illuminate\Support\Env usage #750

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Support Laravel < 6 for Illuminate\Support\Env usage #750

merged 3 commits into from
Oct 1, 2020

Conversation

oytuntez
Copy link
Contributor

Fixed env() and Illuminate\Support\Env usage to support Laravel < 6

@oytuntez
Use Env::get instead of env
e10d562 
It conflicts with other `env()` global functions (such as CakePHP), and most of them don't handle closures.
@oytuntez
Support Laravel < 6 for Illuminate\Support\Env usage
3e43ad3 
Fixed `env()` and `Illuminate\Support\Env` usage to support Laravel < 6
This was referenced Sep 20, 2020
Merged
Closed
@3ffusi0on
Copy link

This is a must needed change as it currently breaks older versions.
Thanks in advance for the merge

PatrikCo
PatrikCo reviewed Sep 29, 2020
View reviewed changes
Copy link

@PatrikCo PatrikCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixed the error. Thanks. Hope this gets merged upstream asap.

@iwasherefirst2
Copy link
Collaborator

In my opinion we should just use env for all Laravel versions 4- 8. Haven't seen any reason yet not do use the default recommended env function.

@mcamara
Copy link
Owner

mcamara commented Sep 30, 2020

@oytuntez can you fix the conflicts please? 😄

@ntold
Copy link

ntold commented Sep 30, 2020

Fixed it for me as well @luntovsky 😎👌

@oytuntez
Copy link
Contributor Author

oytuntez commented Oct 1, 2020

@mcamara done!

@mcamara
Copy link
Owner

mcamara commented Oct 1, 2020

Thanks a lot @oytuntez , I'll merge it and create a new release!

@mcamara mcamara merged commit 4f0bfd8 into mcamara:master Oct 1, 2020
@PoLaKoSz PoLaKoSz mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrikCo PatrikCo PatrikCo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oytuntez @3ffusi0on @iwasherefirst2 @mcamara @ntold @PatrikCo