Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import in LocaleCookieRedirect #674

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix missing import in LocaleCookieRedirect #674

merged 2 commits into from
Oct 25, 2019

Conversation

nikazooz
Copy link
Contributor

Change introduced with 15d3786 had left LocaleCookieRedirect middleware unusable as LanguageNegotiator wasn't imported. This PR fixes the problem by adding the missing import.

Besides that, cookie redirect middleware and session redirect middleware used inconsistent code style (indentation, empty spaces, line length...) so that is taken care of as well 🙂

Have a nice day, cheers! 🙂

@iwasherefirst2
Copy link
Collaborator

Awesome! Thank you.

@iwasherefirst2 iwasherefirst2 requested review from iwasherefirst2 and removed request for iwasherefirst2 October 22, 2019 15:52
@mcamara
Copy link
Owner

mcamara commented Oct 25, 2019

Thanks for your help, I'll merge it and create a new version straightaway!

@mcamara mcamara merged commit 72a2285 into mcamara:master Oct 25, 2019
@nikazooz nikazooz deleted the missing-import branch October 25, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants