Fixed getLocalizedURL producing duplicate query string #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens for non translated routes
|
Thanky you! Great that you also added the test, we strongly need more code coverage. This PR fixes #670 |
|
Awesome! Thanks, it will be released soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there, first pull request for me on this project
I have a bug on production with your package.
I have an non-translated route where I use the middleware 'LocaleSessionRedirect'.
'LocaleSessionRedirect' uses the 'getLocalizedURL' method which produce an url with a duplicate query string.
In my opinion the query string should be removed from the variable '$url' even when is is empty to begin with
I added the tests along the patch. ( the test wasn't passing before the patch )