Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stagecolor fixes #1632

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Conversation

hjtappe
Copy link
Contributor

@hjtappe hjtappe commented Oct 28, 2024

Some fixes to the stagecolors branch as discussed in commit
6cd67bd#diff-7836f394b259eeac1462b437b8f6cc7774694630be49d08e2468ba2a3cf17f3eR143

Update of balls.js still and merge of marquee and alternate still pending.

@coveralls
Copy link

coveralls commented Oct 28, 2024

Coverage Status

coverage: 31.61%. remained the same
when pulling 90d14b0 on hjtappe:stagecolor-fixes
into 7a52145 on mcallegari:stagecolors.

@hjtappe
Copy link
Contributor Author

hjtappe commented Oct 28, 2024

I have merged the three balls* scripts now into just the balls.js.
Please review.
What's missing is the modification around RGBAlgorithmColorDisplayCount which should become v4 ui/ code specific, but that could be another PR - or it is fixed with your efforts to update the QML ui code.

@hjtappe hjtappe marked this pull request as ready for review October 28, 2024 21:13
@mcallegari mcallegari merged commit e490a6a into mcallegari:stagecolors Nov 1, 2024
8 of 9 checks passed
@mcallegari
Copy link
Owner

Merged, thanks
I'll update the QML UI too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants