Introduce keyboard scroll flag in Virtual Console #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QLineEdit in assignhotkey.ui intercepts several key events, (e.g. backspace, delete, home, end, left and right arrows...). Replace the QLineEdit with a simple QLabel to improve key capture. Moreover, inhibit completely the CTRL+<key> combinations.
Introduce in Virtual Console Settings a flag to enable/disable standard keyboard management on scroll area. The flag, when enabled (default), guarantees current behaviour: arrow keys and PgUp/PgDown keys are used to scroll the console and cannot be used as key combinations for controls. When disabled, the scroll area does not consume key events anymore, leaving all the keys available as key combinations on the controls.
7819768 to
e0912e5
Compare
|
Hi @qfulmina , did you hava a chance to try this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second try to fix #1443, after a first attempt with pull request #1584 that covered only VCButtons.
The approach on this change is completely different: introduce a flag to choose whether or not to use arrow and PgUp/PgDown keys to scroll Virtual Console.
When the flag is disabled, all the keys are available as key combinations on the controls.
Side changes:
Closes #1443