Mark all shifted indices unsafe in gradients #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #85
Here the crucial part is
tuple(), tuple(𝒶𝓍i, 𝒶𝓍j)
: the first set of indices are safe to multi-thread, the second are not, so this will be done sequentially:This also affects convolutions like
@tullio a[i] := b[i-k] * c[k]
, which won't multi-thread at all.Should add a test, perhaps to GPU set.