Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ts/components/detourMap): move state up in tree #2364

Merged
merged 12 commits into from
Jan 23, 2024
Merged

refactor(ts/components/detourMap): move state up in tree #2364

merged 12 commits into from
Jan 23, 2024

Conversation

firestack
Copy link
Member

Refactors the state from <DetourMap/> into <DiversionPage/>

@firestack firestack self-assigned this Jan 17, 2024
@github-actions GitHub Actions
Copy link

Coverage of commit bd637c7

Summary coverage rate:
  lines......: 94.4% (3037 of 3218 lines)
  functions..: 72.6% (1251 of 1723 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack marked this pull request as ready for review January 17, 2024 15:19
@firestack firestack requested a review from a team as a code owner January 17, 2024 15:19
@github-actions GitHub Actions
Copy link

Coverage of commit d3b6b5b

Summary coverage rate:
  lines......: 94.4% (3038 of 3218 lines)
  functions..: 72.7% (1252 of 1723 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@firestack firestack force-pushed the kf/refactor/detour-map branch from fd624b0 to ce25b30 Compare January 18, 2024 14:16
@github-actions GitHub Actions
Copy link

Coverage of commit ce25b30

Summary coverage rate:
  lines......: 94.4% (3038 of 3218 lines)
  functions..: 72.7% (1252 of 1723 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@github-actions GitHub Actions
Copy link

Coverage of commit ce25b30

Summary coverage rate:
  lines......: 94.4% (3038 of 3218 lines)
  functions..: 72.7% (1252 of 1723 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Base automatically changed from jdl/feat/api-call-for-new-waypoints to main January 18, 2024 18:42
@firestack firestack force-pushed the kf/refactor/detour-map branch from ce25b30 to 06c7177 Compare January 18, 2024 18:48
@github-actions GitHub Actions
Copy link

Coverage of commit 06c7177

Summary coverage rate:
  lines......: 94.4% (3038 of 3218 lines)
  functions..: 72.7% (1252 of 1723 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

joshlarson
joshlarson reviewed Jan 18, 2024
View reviewed changes
assets/tests/hooks/useDetour.test.ts
)
})

test("when `undoLastWaypoint` is called, removes the last `waypoint`", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want a test asserting that when undoLastWaypoint is called, the API is called again?

Copy link
Member Author

@firestack firestack Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f8e1c77

firestack and others added 12 commits January 22, 2024 09:10
@firestack
refactor(ts/components/detourMap): move state out into hook
decc32b
@firestack
refactor(ts/components/detourMap): remove setWaypoints from public api
11bc790
@firestack
refactor(ts/components/detourMap): reduce useDetour API merge `RouteS…
5000673 
…hapeWithDetour` into `DetourMap`
@firestack
refactor(ts/components/detors): move DetourMap state into `Diversio…
9e369cd 
…nPage`
@joshlarson @firestack
fix: memoize originalShape in DiversionPage
30374cc
@firestack
fixup! refactor(ts/components/detors): move DetourMap state into `D…
bfe2bab 
…iversionPage`
@firestack
fixup! refactor(ts/components/detors): move DetourMap state into `D…
76133e0 
…iversionPage`
@firestack @joshlarson
fix(ts/components/diversionPage): fix useEffect firing via memo
fec7ace 
Co-authored-by: Josh Larson <jlarson@mbta.com>
@firestack
refactor(): convert LatLngLiteral to ShapePoint
ac36f36
@firestack
feedback:refactor(ts/detours): split useDetour into own file
9718937
@firestack
feat:test(ts/hooks/useDetour): test that undoLastWaypoint calls API
f8e1c77
@firestack
feedback:fix:test(ts/hooks/useDetour): return different results from …
6adef00 
…the API input
@firestack firestack force-pushed the kf/refactor/detour-map branch from baef5e3 to 6adef00 Compare January 22, 2024 14:11
@github-actions GitHub Actions
Copy link

Coverage of commit 6adef00

Summary coverage rate:
  lines......: 94.4% (3038 of 3218 lines)
  functions..: 72.7% (1252 of 1723 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

lemald
lemald approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@lemald lemald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally think this looks good!

@firestack firestack merged commit 305065d into main Jan 23, 2024
9 checks passed
@firestack firestack deleted the kf/refactor/detour-map branch January 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlarson joshlarson joshlarson approved these changes

@lemald lemald lemald approved these changes

Assignees

@firestack firestack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@firestack @joshlarson @lemald