tweak: more descriptive log

mbta · Feb 7, 2025 · f669287 · f669287
1 parent 7ce2a8b
commit f669287
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/lib/skate/telemetry.ex b/lib/skate/telemetry.ex
@@ -8,25 +8,26 @@ defmodule Skate.Telemetry do
     :telemetry.attach(
       "skate",
       [:skate, :repo, :query],
-      &Skate.Telemetry.handle_event/4,
+      &Skate.Telemetry.repo_query_telemetry/4,
       %{}
     )
   end
 
-  def handle_event(
+  def repo_query_telemetry(
         [:skate, :repo, :query],
         %{decode_time: decode_time, query_time: query_time, total_time: total_time},
         %{
-          source: "detours",
+          source: source,
           result: {:ok, %{connection_id: connection_id, num_rows: num_rows}},
           query: query
         },
         _config
-      ) do
+      )
+      when source in ["detours"] do
     Logger.info(fn ->
-      "Telemetry for Detours query, connection_id=#{connection_id} num_rows=#{num_rows} decode_time=#{decode_time} query_time=#{query_time} total_time=#{total_time} query='#{query}'"
+      "Telemetry for db query, source=#{source} connection_id=#{connection_id} num_rows=#{num_rows} decode_time=#{decode_time} query_time=#{query_time} total_time=#{total_time} query='#{query}'"
     end)
   end
 
-  def handle_event(_event, _measurements, _metadata, _config), do: nil
+  def repo_query_telemetry(_event, _measurements, _metadata, _config), do: nil
 end
diff --git a/test/skate/telemetry_test.exs b/test/skate/telemetry_test.exs
@@ -39,6 +39,6 @@ defmodule Skate.TelemetryTest do
                       source: "detours"
                     }}
 
-    assert log =~ "Telemetry for Detours query"
+    assert log =~ "Telemetry for db query, source=detours"
   end
 end