Skip to content

Commit

Permalink
chore: Remove User.in_test_group?/2, which isn't called anywhere (#2357)
Browse files Browse the repository at this point in the history
  • Loading branch information
joshlarson authored Jan 10, 2024
1 parent 36257e0 commit d49e802
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 31 deletions.
7 changes: 0 additions & 7 deletions lib/skate/settings/user.ex
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,6 @@ defmodule Skate.Settings.User do
Skate.Repo.all(from(u in users_for_route_ids_query(route_ids), select: u.id))
end

def in_test_group?(user_id, test_group_name) do
user_id
|> get_by_id!()
|> all_test_group_names()
|> Enum.member?(test_group_name)
end

def all_test_group_names(user) do
user = Skate.Repo.preload(user, :test_groups)

Expand Down
24 changes: 0 additions & 24 deletions test/skate/settings/user_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -119,30 +119,6 @@ defmodule Skate.Settings.UserTest do
end
end

describe "in_test_group?/2" do
test "returns true only if given is in test group" do
user_1 = User.upsert(@username, @email)
user_2 = User.upsert("otheruser", "otheruser@test.com")
{:ok, target_test_group} = TestGroup.create("target_test_group")
{:ok, other_test_group} = TestGroup.create("other_test_group")

target_test_group = TestGroup.update(%{target_test_group | users: [user_1, user_2]})
other_test_group = TestGroup.update(%{other_test_group | users: [user_2]})
assert User.in_test_group?(user_1.id, target_test_group.name)
refute User.in_test_group?(user_1.id, other_test_group.name)
end

test "returns true if the test group has an override enabled" do
user_1 = User.upsert(@username, @email)
user_2 = User.upsert("otheruser", "otheruser@test.com")
{:ok, overridden_test_group} = TestGroup.create("overridden_test_group")

overridden_test_group = TestGroup.update(%{overridden_test_group | override: :enabled})
assert User.in_test_group?(user_1.id, overridden_test_group.name)
assert User.in_test_group?(user_2.id, overridden_test_group.name)
end
end

describe "all_test_group_names/1" do
test "returns an empty array if there are no test groups" do
user = User.upsert("user", "user@test.com")
Expand Down

0 comments on commit d49e802

Please sign in to comment.