-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hide CR timetable in the presence of special alerts #2301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulswartz
force-pushed
the
ps-cr-alerts-hide-timetable
branch
from
January 3, 2025 19:56
d2c8407
to
aaf921d
Compare
paulswartz
force-pushed
the
ps-cr-alerts-hide-timetable
branch
from
January 7, 2025 17:01
c546788
to
f945883
Compare
thecristen
reviewed
Jan 7, 2025
test/dotcom_web/controllers/schedule/timetable_controller_test.exs
Outdated
Show resolved
Hide resolved
paulswartz
force-pushed
the
ps-cr-alerts-hide-timetable
branch
from
January 8, 2025 14:29
6ada120
to
ca24b5c
Compare
@thecristen I made the changes as |
thecristen
reviewed
Jan 9, 2025
else | ||
alerts | ||
end | ||
Enum.uniq_by(alerts, & &1.id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
thecristen
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!! Thanks so much 👍🏼
paulswartz
force-pushed
the
ps-cr-alerts-hide-timetable
branch
from
January 9, 2025 21:03
ca24b5c
to
f8fcfcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: CR disruption timetable improvements
This adds special-case handling for two types of alerts where we want to hide the timetable from view. One case is expected to have a PDF as the URL for the alert, and the other does not. In the PDF case, we hide the timetable and provide the link to the PDF. In the other, we hide the timetable and say "PDF upcoming."
This also changes the rendering of the alert to drop the special-case text, and to say "View PDF schedule" if the PDF link is available.
General checks
New UI, or substantial UI changes
New endpoints, or non-trivial changes to current endpoints