Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove paths-ignore from CI Github Action config #2201

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

joshlarson
Copy link
Contributor

I've had a few PR's recently that got stuck in a state where there was a build that was required, but that was configured not to run. That has prevented those PR's from being merge-able (Cristen was able to merge them using her magic admin powers, but it's not good to rely on that).

Documentation on required status checks suggests that it's not a good idea to use paths-ignore for required checks.

Impacted PR's:

@joshlarson joshlarson marked this pull request as ready for review October 22, 2024 17:45
@joshlarson joshlarson requested a review from a team as a code owner October 22, 2024 17:45
@joshlarson joshlarson enabled auto-merge (squash) October 22, 2024 18:08
@joshlarson joshlarson merged commit 6c1d1b1 into main Oct 22, 2024
26 checks passed
@joshlarson joshlarson deleted the jdl/fix-remove-paths-ignore branch October 22, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants