Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up dev preview page for Trip Planner WIP #2124

Merged
merged 9 commits into from
Jul 18, 2024
Merged

Conversation

thecristen
Copy link
Collaborator

Summary of changes

Asana Ticket: Set up dev preview page for Trip Planner WIP

Instead of hacking at the current trip planner incrementally, we'll use a fresh view to start implementing the desired UX/UI changes. This page will be shared across the team for iterative feedback while we explore new ways of grouping and displaying itineraries.

Tip

Visit /preview/trip-planner using the basic auth username/password (this is in 1Password under "Dotcom Basic Auth" in the Website Dev vault for prod/dev/dev-blue/dev-green, or locally with BASIC_AUTH_USERNAME and BASIC_AUTH_PASSWORD environment variables)

image

@thecristen thecristen requested a review from a team as a code owner July 10, 2024 14:04
@thecristen thecristen requested a review from bklebe July 10, 2024 14:04
@thecristen thecristen added the dev-green Deploy to dev-green label Jul 10, 2024
@anthonyshull anthonyshull removed the dev-green Deploy to dev-green label Jul 10, 2024
Copy link
Contributor

@bklebe bklebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this deployed anywhere in staging or dev so we can verify the basic functionality works as we believe it should?

@thecristen
Copy link
Collaborator Author

nope, I can deploy it to dev-blue though

@anthonyshull
Copy link
Contributor

Is this deployed anywhere in staging or dev so we can verify the basic functionality works as we believe it should?

You can just run it locally.

@bklebe
Copy link
Contributor

bklebe commented Jul 18, 2024

Is this deployed anywhere in staging or dev so we can verify the basic functionality works as we believe it should?

You can just run it locally.

I could, but I'm more confident in the similarity of dev and prod than prod and my workstation :)

@thecristen thecristen removed the dev-blue Deploy to dev-blue label Jul 18, 2024
@bklebe
Copy link
Contributor

bklebe commented Jul 18, 2024

Excellent, was able to check that the page is working on dev. Thanks so much!

@thecristen thecristen merged commit 66d0bcd into main Jul 18, 2024
23 of 28 checks passed
@thecristen thecristen deleted the trip-planner-preview branch July 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants