Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused combined_route? function #1808

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

arkadyan
Copy link
Contributor

Summary of changes

No Asana ticket. Just a drive-by change I noticed while copying API files out.

fix: Remove unused combined_route? function

This was added in PR #1099. The rest of the code added in that PR was later removed in PR #1146, but this function was missed.


General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@arkadyan arkadyan requested a review from a team as a code owner November 27, 2023 17:04
@arkadyan arkadyan requested a review from kotva006 November 27, 2023 17:04
This was added in PR #1099. The rest of the code added in that PR was
later removed in PR #1146, but this function was missed.
@arkadyan arkadyan force-pushed the mss-dead-code-removal branch from d0ba745 to 34344d6 Compare November 29, 2023 15:17
@arkadyan arkadyan merged commit 643b467 into master Nov 29, 2023
17 of 18 checks passed
@arkadyan arkadyan deleted the mss-dead-code-removal branch November 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants