Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autocomplete): fix width in the header desktop + component improvements #1804

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

thecristen
Copy link
Collaborator

@thecristen thecristen commented Nov 24, 2023

Summary of changes

Asana Ticket: Mostly no ticket, but final commit fixes Search bar visual bug

This is the base branch for #1805

  • Styling changes to fix the visual bug
  • For the algolia_autocomplete component:
    • Makes the placeholder attribute configurable (keep the current value as the default)
    • Changes how data-algolia attribute is populated slightly: using a nil value here will allow the attribute to the omitted. Makes the output a bit cleaner / easier to test.
    • Adds an attribute to indicate the desired event handler for the autocomplete's onStateChange property. I'm open to feedback on this because it's a little hacky-looking to me (it depends on a JS object with certain key names), but I wasn't sure of a better way to make onStateChange configurable from the Elixir templates.

General checks

  • Are the changes organized into self-contained commits with descriptive and well-formatted commit messages? This is a good practice that can facilitate easier reviews.
  • Testing. Do the changes include relevant passing updates to tests? This includes updating screenshots. Preferably tests are run locally to verify that there are no test failures created by these changes, before opening a PR.
  • Tech debt. Have you checked for tech debt you can address in the area you're working in? This can be a good time to address small issues, or create Asana tickets for larger issues.

@thecristen thecristen requested a review from a team as a code owner November 24, 2023 19:02
@thecristen thecristen merged commit e689718 into master Nov 29, 2023
@thecristen thecristen deleted the cbj/search-autocomplete-refinements branch November 29, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants