fix: Don't overwrite deps directories in docker-composeed containers

mbta · Oct 2, 2024 · 38a39b8 · 38a39b8
1 parent 6ba2846
commit 38a39b8
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/deploy/dev.yml b/deploy/dev.yml
@@ -50,6 +50,8 @@ services:
             timeout: 10s
         volumes:
             - ../:/app
+            - /app/deps
+            - /app/assets/node_modules
         networks:
             dotcom_network:
                 ipv4_address: 10.0.0.2
@@ -83,6 +85,8 @@ services:
             timeout: 10s
         volumes:
             - ../:/app
+            - /app/deps
+            - /app/assets/node_modules
         networks:
             dotcom_network:
                 ipv4_address: 10.0.0.3

diff --git a/deploy/dotcom/dev/1/Dockerfile b/deploy/dotcom/dev/1/Dockerfile
@@ -10,10 +10,12 @@ COPY mix.exs .
 COPY mix.lock .
 COPY package.json .
 COPY assets/package.json ./assets/package.json
+COPY assets/package-lock.json ./assets/package-lock.json
 
 RUN mix local.hex --force
 RUN mix local.rebar --force
 
 RUN mix deps.get
-RUN npm --prefix assets install --package-lock-only --ignore-scripts --no-save --audit false --fund false --loglevel verbose
+RUN npm run install --ignore-scripts --audit false --fund false --loglevel verbose
+
 CMD elixir --sname dotcom1 --cookie foobarbaz -S mix phx.server
diff --git a/deploy/dotcom/dev/2/Dockerfile b/deploy/dotcom/dev/2/Dockerfile
@@ -8,5 +8,14 @@ WORKDIR /app
 
 COPY mix.exs .
 COPY mix.lock .
+COPY package.json .
+COPY assets/package.json ./assets/package.json
+COPY assets/package-lock.json ./assets/package-lock.json
+
+RUN mix local.hex --force
+RUN mix local.rebar --force
+
 RUN mix deps.get
+RUN npm run install --ignore-scripts --audit false --fund false --loglevel verbose
+
 CMD elixir --sname dotcom2 --cookie foobarbaz -S mix phx.server