forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution] Deletes Old Timeline Code (elastic#196243)
## Summary Fixes elastic/security-team#9676 This is follow up of the PR : elastic#195959 where we had removed feature flag `unifiedComponentsInTimelineDisabled`. This PR completes unified components migration in Timeline. ## Changes Most changes in this PR are : 1. Deletion for the obsolete code. 2. Refactoring of needed utils ( only 3. have marked in comments below ) 3. Updating import path of above utils.
- Loading branch information
Showing
92 changed files
with
212 additions
and
7,104 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
x-pack/plugins/security_solution/public/common/utils/get_mapped_non_ecs_value.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import type { TimelineNonEcsData } from '@kbn/timelines-plugin/common'; | ||
| import { getMappedNonEcsValue, useGetMappedNonEcsValue } from './get_mapped_non_ecs_value'; | ||
| import { renderHook } from '@testing-library/react-hooks'; | ||
|
|
||
| describe('getMappedNonEcsValue', () => { | ||
| it('should return the correct value', () => { | ||
| const data: TimelineNonEcsData[] = [{ field: 'field1', value: ['value1'] }]; | ||
| const fieldName = 'field1'; | ||
| const result = getMappedNonEcsValue({ data, fieldName }); | ||
| expect(result).toEqual(['value1']); | ||
| }); | ||
|
|
||
| it('should return undefined if item is null', () => { | ||
| const data: TimelineNonEcsData[] = [{ field: 'field1', value: ['value1'] }]; | ||
| const fieldName = 'field2'; | ||
| const result = getMappedNonEcsValue({ data, fieldName }); | ||
| expect(result).toEqual(undefined); | ||
| }); | ||
|
|
||
| it('should return undefined if item.value is null', () => { | ||
| const data: TimelineNonEcsData[] = [{ field: 'field1', value: null }]; | ||
| const fieldName = 'non_existent_field'; | ||
| const result = getMappedNonEcsValue({ data, fieldName }); | ||
| expect(result).toEqual(undefined); | ||
| }); | ||
|
|
||
| it('should return undefined if data is undefined', () => { | ||
| const data = undefined; | ||
| const fieldName = 'field1'; | ||
| const result = getMappedNonEcsValue({ data, fieldName }); | ||
| expect(result).toEqual(undefined); | ||
| }); | ||
|
|
||
| it('should return undefined if data is empty', () => { | ||
| const data: TimelineNonEcsData[] = []; | ||
| const fieldName = 'field1'; | ||
| const result = getMappedNonEcsValue({ data, fieldName }); | ||
| expect(result).toEqual(undefined); | ||
| }); | ||
| }); | ||
|
|
||
| describe('useGetMappedNonEcsValue', () => { | ||
| it('should return the correct value', () => { | ||
| const data: TimelineNonEcsData[] = [{ field: 'field1', value: ['value1'] }]; | ||
| const fieldName = 'field1'; | ||
| const { result } = renderHook(() => useGetMappedNonEcsValue({ data, fieldName })); | ||
| expect(result.current).toEqual(['value1']); | ||
| }); | ||
| }); |
40 changes: 40 additions & 0 deletions
40
x-pack/plugins/security_solution/public/common/utils/get_mapped_non_ecs_value.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import type { TimelineNonEcsData } from '@kbn/timelines-plugin/common'; | ||
| import { useMemo } from 'react'; | ||
|
|
||
| export const getMappedNonEcsValue = ({ | ||
| data, | ||
| fieldName, | ||
| }: { | ||
| data?: TimelineNonEcsData[]; | ||
| fieldName: string; | ||
| }): string[] | undefined => { | ||
| /* | ||
| While data _should_ always be defined | ||
| There is the potential for race conditions where a component using this function | ||
| is still visible in the UI, while the data has since been removed. | ||
| To cover all scenarios where this happens we'll check for the presence of data here | ||
| */ | ||
| if (!data || data.length === 0) return undefined; | ||
| const item = data.find((d) => d.field === fieldName); | ||
| if (item != null && item.value != null) { | ||
| return item.value; | ||
| } | ||
| return undefined; | ||
| }; | ||
|
|
||
| export const useGetMappedNonEcsValue = ({ | ||
| data, | ||
| fieldName, | ||
| }: { | ||
| data?: TimelineNonEcsData[]; | ||
| fieldName: string; | ||
| }): string[] | undefined => { | ||
| return useMemo(() => getMappedNonEcsValue({ data, fieldName }), [data, fieldName]); | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.