This repository has been archived by the owner on Jul 22, 2022. It is now read-only.
Vue3 initial work #170
Merged
Vue3 initial work #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazipan
reviewed
Feb 16, 2022
|
If you're happy it's ready to go. However, we could look at implementing our own version of vue-scriptx inside the package. |
|
Any update on getting this update in? I'm also in the process of updating my site to vue 3 and would be great if this package could work with it! |
|
Anything else needed before we merge @mazipan ? |
|
I recently developed a site with vue 3, it would be great if this feature was implemented. |
mazipan
added a commit
that referenced
this pull request
Mar 21, 2022
* Vue3 initial work (#170) * Upgrade to Vue3 * Fix Eslint * Bump version * Bump version * feat: prepare vue3 support release * ci: update pnpm on ci * chore: change gh template Co-authored-by: James Harrison <james@fasttortoise.co.uk> Co-authored-by: Irfan Maulana (@mazipan) <maulana.irfan@tokopedia.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Thank you for the PR!
Description:
Some initial work to support Vue3
Issue Reference
#158