upgrade PHPUnit to version 10 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html
Treggats
commented
Apr 6, 2023
| @@ -33,4 +33,4 @@ jobs: | |||
| run: composer install --prefer-dist --no-interaction | |||
|
|
|||
| - name: Execute tests | |||
| run: vendor/bin/phpunit --verbose | |||
There was a problem hiding this comment.
flag has been removed
Treggats
commented
Apr 6, 2023
| stopOnFailure="false" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" | ||
| > | ||
| bootstrap="vendor/autoload.php" |
There was a problem hiding this comment.
config upgraded using PHPUnit --migrate-configuration flag
Treggats
commented
Apr 6, 2023
| { | ||
| /** @test */ | ||
| #[Test] |
There was a problem hiding this comment.
annotation is replaced by an attribute
Treggats
commented
Apr 6, 2023
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| abstract class TestCase extends Orchestra | |||
| { | |||
| public function setUp(): void | |||
| protected function setUp(): void | |||
There was a problem hiding this comment.
access modifier has changed in PHPUnit 10
6182328 to
a6da785
Compare
Treggats
commented
Apr 6, 2023
| @@ -33,4 +33,4 @@ jobs: | |||
| run: composer install --prefer-dist --no-interaction | |||
|
|
|||
| - name: Execute tests | |||
| run: vendor/bin/phpunit --verbose | |||
| run: vendor/bin/phpunit --no-coverage | |||
There was a problem hiding this comment.
added the --no-coverage flag to override the configured coverage config
Treggats
commented
Apr 6, 2023
| @@ -32,19 +33,7 @@ public function it_wont_set_headers_if_it_is_not_enabled_in_the_config(): void | |||
| $this->get('test-route')->assertHeaderMissing('Permissions-Policy'); | |||
| } | |||
|
|
|||
| /** @test */ | |||
| public function it_throws_an_invalid_policy_class_exception_when_using_an_invalid_policy(): void | |||
There was a problem hiding this comment.
this is more likely an framework issue and not one that a package should check for
Treggats
commented
Apr 6, 2023
| @@ -80,6 +80,13 @@ jobs: | |||
| - name: Install Composer dependencies | |||
| run: composer install --prefer-dist --no-interaction | |||
|
|
|||
| - name: Rector Cache | |||
There was a problem hiding this comment.
In the CI cache the cache for Rector
Treggats
commented
Apr 6, 2023
| @@ -26,6 +27,9 @@ | |||
| __DIR__ . '/tests', | |||
| ]); | |||
|
|
|||
| $rectorConfig->cacheClass(FileCacheStorage::class); | |||
There was a problem hiding this comment.
set Rector to use file based storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change or introduce
PHPUnit 10 upgrade
What is the impact of these changes
Running tests
Checklist
Steps to reproduce / test
Run the tests