Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11] add eigenschappen #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Floris272
Copy link
Contributor

@Floris272 Floris272 commented Mar 7, 2025

Fixes #11

Changes

  • Adds producttypen.Eigenschap & producten.ProductEigenschap models
  • Eigenschappen can be created/updated within the producttype serializer
  • ProductEigenschap can be created/updated within the product serializer using naam/waarde

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 95.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.38%. Comparing base (f00b267) to head (21912b0).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...n_producten/producten/models/product_eigenschap.py 84.00% 3 Missing and 1 partial ⚠️
...open_producten/producten/serializers/validators.py 81.81% 2 Missing ⚠️
...c/open_producten/producttypen/models/eigenschap.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   84.92%   86.38%   +1.45%     
==========================================
  Files         106      118      +12     
  Lines        2269     2526     +257     
  Branches      149      160      +11     
==========================================
+ Hits         1927     2182     +255     
+ Misses        319      318       -1     
- Partials       23       26       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Floris272 Floris272 marked this pull request as ready for review March 7, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Producttype eigenschappen : is analoog aan zaaktype eigenschappen
2 participants