Applied generate_oas_component_cached() where applicable #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8da012 to
b434cfa
Compare
added 3 commits
January 25, 2024 09:48
…setUp(self) instance methods and `generate_oas_component_cached`
b434cfa to
bcf1434
Compare
stevenbal
approved these changes
Jan 29, 2024
pi-sigma
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's use
generate_oas_component_cached()in all the relevant setUp()'s and see what it does for test runtime.I also refactored/restored some ZGW tests that earlier sacrificed test-isolation for performance, by using the setupTestData class-method, but this is no longer needed. This is slightly slower because the normal factories run for every tests but it is safer and more correct.