Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#2025] Daily email digest to inform admins about failed emails #976

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 19, 2024

@stevenbal stevenbal marked this pull request as draft January 19, 2024 16:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (794d3ba) 94.79% compared to head (e4407c3) 94.79%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #976   +/-   ##
========================================
  Coverage    94.79%   94.79%           
========================================
  Files          859      860    +1     
  Lines        30120    30125    +5     
========================================
+ Hits         28553    28558    +5     
  Misses        1567     1567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/2025-daily-email-digest-failed-emails branch from e4407c3 to fe6a23f Compare January 22, 2024 11:52
@stevenbal stevenbal changed the title 🚧 [#2025] ✨ [#2025] Daily email digest to inform admins about failed emails Jan 22, 2024
@stevenbal stevenbal force-pushed the feature/2025-daily-email-digest-failed-emails branch from fe6a23f to 923e7fa Compare January 22, 2024 11:54
@stevenbal stevenbal marked this pull request as ready for review January 22, 2024 11:54
@stevenbal stevenbal requested a review from alextreme January 22, 2024 11:54
@alextreme alextreme requested a review from pi-sigma January 22, 2024 15:00
@stevenbal stevenbal force-pushed the feature/2025-daily-email-digest-failed-emails branch from 923e7fa to 3903c67 Compare January 22, 2024 16:20
@stevenbal stevenbal requested a review from pi-sigma January 22, 2024 16:20
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a PR cronjobs.conf in deployment, otherwise I'll overlook it: https://bitbucket.org/maykinmedia/maykin-deployment/src/master/projects/open-inwoner/cronjobs.conf

@alextreme alextreme merged commit 28dc356 into develop Jan 29, 2024
14 checks passed
@alextreme alextreme deleted the feature/2025-daily-email-digest-failed-emails branch January 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants