🐛 [#1961] Implement redirect after DigiD/eHerkenning OIDC login #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alextreme I'll leave this for now, the whole middleware redirect thing is getting too complicated (hence the failing tests) |
|
Agreed, lets take a look together at a later stage and discuss with @pi-sigma what a better approach would be |
26abb83 to
8d95377
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #960 +/- ##
===========================================
+ Coverage 94.92% 94.97% +0.04%
===========================================
Files 882 882
Lines 30863 31066 +203
===========================================
+ Hits 29298 29506 +208
+ Misses 1565 1560 -5 ☔ View full report in Codecov by Sentry. |
8d95377 to
4f3003d
Compare
Bartvaderkin
suggested changes
Feb 26, 2024
4f3003d to
d62da79
Compare
Bartvaderkin
approved these changes
Feb 27, 2024
d62da79 to
af28734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1961