Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#1975] Keep previous selection when selecting new files to upload #936

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

stevenbal
Copy link
Contributor

Comment on lines +216 to +219
if (e && e.type === 'change') {
files = [...(this.files || []), ...files]
this.addFiles(files, true)
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't really find another way to fix this bug for selecting files using the button/window, because it seems to be default behavior to immediately override the input's files, so the previously selected files need to be stored somewhere.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is an incredibly difficult aspect of the default behaviour for the HTML file-input type 😢

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! Just a thought: instead of adding this to "issue" branch/dir, it could also have been added to our "fix" branch in this project?

Comment on lines +216 to +219
if (e && e.type === 'change') {
files = [...(this.files || []), ...files]
this.addFiles(files, true)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is an incredibly difficult aspect of the default behaviour for the HTML file-input type 😢

@stevenbal
Copy link
Contributor Author

stevenbal commented Jan 8, 2024

Just a thought: instead of adding this to "issue" branch/dir, it could also have been added to our "fix" branch in this project?

@jiromaykin do you mean using fix/1975-multiple-doc-upload as the branch name, instead of issue/1975-multiple-doc-upload? I've always used feature/... or issue/... (out of habit), though if we want to use fix instead of issue for future branches, that's fine by me

@alextreme alextreme merged commit e2f4b64 into develop Jan 8, 2024
@alextreme alextreme deleted the issue/1975-multiple-doc-upload branch January 8, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants