-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [#1975] Keep previous selection when selecting new files to upload #936
Conversation
if (e && e.type === 'change') { | ||
files = [...(this.files || []), ...files] | ||
this.addFiles(files, true) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't really find another way to fix this bug for selecting files using the button/window, because it seems to be default behavior to immediately override the input's files, so the previously selected files need to be stored somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is an incredibly difficult aspect of the default behaviour for the HTML file-input type 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! Just a thought: instead of adding this to "issue" branch/dir, it could also have been added to our "fix" branch in this project?
if (e && e.type === 'change') { | ||
files = [...(this.files || []), ...files] | ||
this.addFiles(files, true) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is an incredibly difficult aspect of the default behaviour for the HTML file-input type 😢
@jiromaykin do you mean using |
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1975