[#1976] Ensuring notifications are no longer sticky #919
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #919 +/- ##
========================================
Coverage 93.07% 93.07%
========================================
Files 828 828
Lines 28995 28995
========================================
Hits 26988 26988
Misses 2007 2007 ☔ View full report in Codecov by Sentry. |
| @@ -1,5 +1,4 @@ | |||
| .notifications { | |||
| position: sticky; | |||
There was a problem hiding this comment.
This does mean ALL notifications are no longer sticky, like the approval for newly added contact etc. Do we want this?
There was a problem hiding this comment.
I don't see a value in having the notifications sticky (I think the only reason we did this was to ensure notifications wouldn't interfere with the rest of the design). Consensus with Groningen is non-sticky and a 'wegklik kruisje' for the post-upload MijnAanvragen notification, however your call if you want to make this change overall or not
There was a problem hiding this comment.
This PR will need to either be hijacked by me or put on hold for the future as part of researching what the effect will be: https://taiga.maykinmedia.nl/project/open-inwoner/task/1976
There was a problem hiding this comment.
hijack away or decline, my ego can take it 👍
3039622 to
d675762
Compare
No description provided.