♻️ [#1930] Category personalisation fixes

[stevenbal]

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/1930

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cac5a4) 92.93% compared to head (780d86b) 92.96%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #907      +/-   ##
===========================================
+ Coverage    92.93%   92.96%   +0.02%     
===========================================
  Files          819      820       +1     
  Lines        28250    28358     +108     
===========================================
+ Hits         26255    26363     +108     
  Misses        1995     1995              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stevenbal]

@alextreme I noticed the following:

• To determine the categories shown in the menu, I only use the root nodes and then do the permission filter for the user
• To determine the categories shown in the homepage plugin, I take all nodes (including child nodes), then do permission filtering and then uitgelicht/zaaktypen filtering. This way subcategories can show up in the plugin on the homepage if uitgelicht, but not in the menu, is this what we want? Or do we want to show child nodes in the menu / list directly as well?

[alextreme]

@alextreme I noticed the following:

* To determine the categories shown in the menu, I only use the root nodes and then do the permission filter for the user

* To determine the categories shown in the homepage plugin, I take all nodes (including child nodes), then do permission filtering and then `uitgelicht`/zaaktypen filtering. This way subcategories can show up in the plugin on the homepage if uitgelicht, but not in the menu, is this what we want? Or do we want to show child nodes in the menu / list directly as well?

We don't want to show child nodes in the menu, the idea is that from the category detailpage you can click through and browse the subcategories (if there are any).

I would expect that we also need to update CategoryDetailView in order to make use of the visible_for_user() manager for the subcategories. I don't see that in your PR or on develop, so double-check this just in case.

[alextreme]

Double-check CategoryDetailView

[Bartvaderkin]

Nice, and more test code then functional code 😆