Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#1884] Make cookiebanner be the first element to load #867

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

jiromaykin
Copy link
Contributor

in order to improve Tab order, issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/1884

@jiromaykin jiromaykin self-assigned this Nov 30, 2023
@jiromaykin jiromaykin added the Accessibility Improving accessibility label Nov 30, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (97b4bd8) 92.75% compared to head (5a7a2ee) 92.75%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #867   +/-   ##
========================================
  Coverage    92.75%   92.75%           
========================================
  Files          789      789           
  Lines        27162    27162           
========================================
  Hits         25194    25194           
  Misses        1968     1968           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin marked this pull request as ready for review November 30, 2023 13:04
@alextreme alextreme merged commit c3bc521 into develop Dec 5, 2023
@alextreme alextreme deleted the feature/1884-make-cookiebanner-first-in-DOM branch December 5, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants