[#1739] 🐛 Fix infinite loop for search page filters #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40e79db to
4d6779a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #762 +/- ##
========================================
Coverage 93.58% 93.58%
========================================
Files 697 697
Lines 24595 24595
========================================
Hits 23016 23016
Misses 1579 1579 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Bartvaderkin
suggested changes
Sep 12, 2023
pi-sigma
requested changes
Sep 12, 2023
6d1ac3c to
b62d4c5
Compare
pi-sigma
approved these changes
Sep 13, 2023
Bartvaderkin
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://taiga.maykinmedia.nl/project/open-inwoner/issue/1739
let'instead of 'var' for scopesetIntervalwithsetTimeoutto avoid continuous looping. Code inside setTimeout will execute once after the specified delay (250 milliseconds)timerIdto null instead of zero is a common practice in JavaScript when using variables to represent timers or intervals + makes it clear that the timerId variable is not currently associated with any active timer - a way to indicate that there is no ongoing timer operation.