Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1717] Make warningbanner not overlap opened mobile menu #755

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Sep 4, 2023

Self-identified problem: https://taiga.maykinmedia.nl/project/open-inwoner/task/1717
This needed restructering in the mobile menu in order to push elements to their initial positions.

navigation-menu-headerlogo-disappears

@codecov-commenter
Copy link

Codecov Report

Merging #755 (22c2528) into develop (08a3925) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #755   +/-   ##
========================================
  Coverage    96.34%   96.34%           
========================================
  Files          688      688           
  Lines        24384    24384           
========================================
  Hits         23492    23492           
  Misses         892      892           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the fix/1717-warningbanner-on-mobile branch from 89a0f63 to 938c3bf Compare September 5, 2023 13:39
@jiromaykin jiromaykin force-pushed the fix/1717-warningbanner-on-mobile branch from 74edcbb to 23eecb8 Compare September 5, 2023 13:45
@jiromaykin jiromaykin marked this pull request as ready for review September 5, 2023 13:46
@jiromaykin
Copy link
Contributor Author

@Bartvaderkin This is another one that is waiting for review :-)

@alextreme alextreme merged commit 831f18f into develop Sep 7, 2023
@alextreme alextreme deleted the fix/1717-warningbanner-on-mobile branch September 7, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants