-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1558] Add phonenumber validation #695
[#1558] Add phonenumber validation #695
Conversation
8a6e1ce
to
a2d3bc4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #695 +/- ##
=========================================
Coverage 96.20% 96.20%
=========================================
Files 639 642 +3
Lines 22799 22934 +135
=========================================
+ Hits 21934 22064 +130
- Misses 865 870 +5
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this is accurate and has usability:
- Do we need the distinction for international numbers? Can we still enter local dutch numbers (eg: without country code) if a field has international validator?
- Do we support input of humanized numbers? Eg, with dashes and spaces for readability? Many people write their numbers in groups (06 1234 5678 or 020 123 45 67 or 020-1234567)
If we want make use of international numbers (imo we maybe only need them in the contact form) we need the distinction. When we enter such a number we have to use the country code indeed. Should I remove it and use only dutch numbers? @alextreme what do you think? |
I would recommend to only allow Dutch numbers (10 digits, no spaces, dashes etc). I'd prefer being too strict when it comes to data sent through to a secondary system. |
a2d3bc4
to
1637e69
Compare
Removed international phone validator and now there is only the dutch one. I also added a method for spaces and dashes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor changes and we're good to go.
No description provided.