Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1553] Fix duplicate messages in contact form #687

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jun 21, 2023

When both email and api are activated the success/error message is shown twice.

@vaszig vaszig requested a review from alextreme June 21, 2023 15:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #687 (bf790af) into develop (8c950d2) will decrease coverage by 0.11%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
- Coverage    96.26%   96.16%   -0.11%     
===========================================
  Files          631      633       +2     
  Lines        22466    22668     +202     
===========================================
+ Hits         21628    21799     +171     
- Misses         838      869      +31     
Impacted Files Coverage Δ
src/open_inwoner/openklant/views/contactform.py 92.85% <75.00%> (-0.83%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme requested a review from Bartvaderkin June 22, 2023 08:09
@alextreme alextreme merged commit 2127223 into develop Jun 22, 2023
@alextreme alextreme deleted the fix/1553-duplicated-message-when-openklant-email-and-api-activated branch June 22, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants