[#1524] Make onderwerpen in contact form orderable #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #684 +/- ##
===========================================
- Coverage 96.26% 96.26% -0.01%
===========================================
Files 631 634 +3
Lines 22466 22488 +22
===========================================
+ Hits 21628 21648 +20
- Misses 838 840 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
187a6d1 to
b731c91
Compare
b731c91 to
efa337d
Compare
Bartvaderkin
approved these changes
Jun 22, 2023
Comment on lines
+8
to
+10
| for subject in Subject.objects.all(): | ||
| subject.order = subject.pk | ||
| subject.save() |
There was a problem hiding this comment.
Technically this could have been an Subject.objects.update(order=F('id')) so it doesn't need to load all the records from the database to python and back, but it doesn't matter too much in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.