Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1458] Update klant from profile form data #669

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #669 (26c7a29) into feature/1437-1457-contact-form-klanten (ecfc9fb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                           Coverage Diff                           @@
##           feature/1437-1457-contact-form-klanten     #669   +/-   ##
=======================================================================
  Coverage                                   96.47%   96.48%           
=======================================================================
  Files                                         621      621           
  Lines                                       22069    22147   +78     
=======================================================================
+ Hits                                        21291    21368   +77     
- Misses                                        778      779    +1     
Impacted Files Coverage Δ
.../open_inwoner/accounts/tests/test_profile_views.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/views/profile.py 99.39% <100.00%> (+0.06%) ⬆️
src/open_inwoner/openklant/tests/data.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin marked this pull request as ready for review June 13, 2023 12:20
@Bartvaderkin Bartvaderkin requested a review from vaszig June 13, 2023 12:20
@Bartvaderkin
Copy link
Contributor Author

Sorry I left a bunch of f-strings in here as well. I fixed them in the next PR #670 that builds on this PR.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the "roepnaam"?Is it missing because of e-suite?

@Bartvaderkin
Copy link
Contributor Author

@vaszig the ticket was spurious, as 'roepnaam' doesn't exist in the Klanten API 😆

@vaszig vaszig self-requested a review June 13, 2023 13:59
Base automatically changed from feature/1437-1457-contact-form-klanten to develop June 13, 2023 15:10
@alextreme alextreme merged commit 27db338 into develop Jun 14, 2023
@alextreme alextreme deleted the feature/1458-update-klant-from-profile branch June 14, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants