Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1529] Improve contact-form styles #667

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jun 12, 2023

Contact form needs icon in select + different placeholder text, and styles for textarea.
https://projects.invisionapp.com/share/UF134RWMWCK8#/screens/471596624
In order to just change the Select styles, I needed to break open the form and turn it into a render_form.

Side Note: all Selects in the entire projects should 'actually' have a muted style, but it is impossible to do this with CSS if all fields have a value AND are not 'required' (or else all of the Options inside the Select will look muted) - only required and invalid values can be targeted with CSS across most common browsers.
"...The problem is that these elements have very different default looks across browsers, and while you can style them in some ways, some parts of their internals are literally impossible to style..." (new issue nr.#1556)

@jiromaykin jiromaykin force-pushed the fix/1529-style-contactform branch 4 times, most recently from edf20f8 to 660bddc Compare June 15, 2023 09:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #667 (24c8b86) into develop (47aeb4f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 24c8b86 differs from pull request most recent head 77cb4ae. Consider uploading reports for the commit 77cb4ae to get more accurate results

@@             Coverage Diff             @@
##           develop     #667      +/-   ##
===========================================
+ Coverage    96.24%   96.26%   +0.01%     
===========================================
  Files          631      631              
  Lines        22474    22466       -8     
===========================================
- Hits         21631    21627       -4     
+ Misses         843      839       -4     
Impacted Files Coverage Δ
...en_inwoner/components/templatetags/contact_tags.py 100.00% <ø> (ø)
src/open_inwoner/openklant/forms.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jiromaykin jiromaykin force-pushed the fix/1529-style-contactform branch 5 times, most recently from 7352cb2 to df640bb Compare June 15, 2023 15:22
@jiromaykin
Copy link
Contributor Author

@Bartvaderkin it seems the "ContactFormTestCase" test is faling - wondering which field causes this problem?

@jiromaykin jiromaykin force-pushed the fix/1529-style-contactform branch 2 times, most recently from 24c8b86 to 3bfc2e6 Compare June 19, 2023 15:57
@jiromaykin jiromaykin force-pushed the fix/1529-style-contactform branch from dbf9cc8 to 77cb4ae Compare June 19, 2023 16:03
@jiromaykin jiromaykin marked this pull request as ready for review June 20, 2023 07:37
@alextreme alextreme merged commit 292be1c into develop Jun 21, 2023
@alextreme alextreme deleted the fix/1529-style-contactform branch June 21, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants